Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tables: initial support for row actions #700

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

alexanderpann
Copy link
Collaborator

Tables now support a new property row UI actions (experimental): This property adds actions to the MPS toolbar to add a new row above (up arrow)/below(down arrow) the current row or to delete the current row (x). These actions only work for simple tables that are based on rows. The property is set to false by default.

Copy link
Collaborator

@mgronover mgronover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we have the precondition, that a row always has a specific node<>. This might not be the case for all tables (I am not sure here).
So, if i am right, wouldn't it be good to have this dependency conjuncted with the table property rowUIActions.

@mgronover mgronover self-requested a review November 28, 2023 07:09
@alexanderpann alexanderpann marked this pull request as ready for review November 28, 2023 07:09
@alexanderpann alexanderpann merged commit e6a0c71 into maintenance/mps20213 Nov 28, 2023
1 check passed
@alexanderpann alexanderpann deleted the feature/table_row_actions branch December 7, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants