Benchmarks. Mimic the behavior of Skiko rendering #5215
Conversation
igordmn
force-pushed
the
igor.demin/benchmark-mimic
branch
from
877b8f5 to
18147a6
Compare
Currently, we include the time when we wait for vsync which gives us wrong results
- Draw into an intermediate Picture. Without it benchmarks showed an improvement by 10%, but in fact it was a regression by 10% - Clear Canvas each frame
igordmn
force-pushed
the
igor.demin/benchmark-mimic
branch
from
18147a6 to
1bb85ba
Compare
| private val pictureRecorder = PictureRecorder() | ||
|
|
||
| @OptIn(InternalComposeUiApi::class) | ||
| fun ComposeScene.mimicSkikoRender(surface: Surface, time: Long, width: Int, height: Int) { |
There was a problem hiding this comment.
imo: requires BIG TODO to keep it in sync with skiko implementation, because I'm not sure that it won't be changed there
There was a problem hiding this comment.
Added a comment here
Without reusing the whole renderer from Skiko (which realistically we won't do without a good reason), we should keep it sync manually.
When we merge it, I will add a comment to Skiko:
Note, if you change the rendering logic a lot, notify about this in [this issue](new created issue), because [benchmarks project](link to this function) depends on it
benchmarks/multiplatform/benchmarks/src/commonMain/kotlin/MeasureComposable.kt
Outdated
Show resolved
Hide resolved
| * If Skiko stops using `picture`, we need to remove it here too. | ||
| */ | ||
| @OptIn(InternalComposeUiApi::class) | ||
| fun ComposeScene.mimicSkikoRender(surface: Surface, time: Long, width: Int, height: Int) { |
There was a problem hiding this comment.
I would rename it to reflect what it actually does , f.i renderViaPicture.
There was a problem hiding this comment.
This function should match Skiko’s rendering.
While it currently uses a picture, that’s an implementation detail. If Skiko stops using a picture, we should change the implementation here, without renaming.
It also clears the Canvas, which may impact benchmarking accuracy.
Ideally we should reuse some function from Skiko, but this a much more complex task.
Clear Canvas each frame
Add MavenLocal to becnhmark local versions
Release Notes
N/A