[kotlin][debugger] Add capability to fetch @kotlin.Metadata in the debugger #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuevmaxim
reviewed
Sep 26, 2024
| import kotlin.io.encoding.ExperimentalEncodingApi | ||
|
|
||
| fun ReferenceType.fetchKotlinMetadata(context: EvaluationContext): KotlinClassMetadata? { | ||
| val classObject = classObject() ?: return null |
There was a problem hiding this comment.
We can cache the result of this function to avoid redundant computations
There was a problem hiding this comment.
I also thought about creating a metadata cache. We need a cache that would invalidate itself when the debug process stops. The only issue is that I didn't find any 'debug process wise' caches in Intellij IDEA. Only project wide ones are used in the Kotlin debugger.
nikita-nazarov
force-pushed
the
nazarov/metadata-in-debugger
branch
from
1dc6149 to
ea15856
Compare
nikita-nazarov
force-pushed
the
nazarov/metadata-in-debugger
branch
from
ea15856 to
207800e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As personally discussed with @zuevmaxim