IDEA-358562 Created projects via wizard defines Daemon JVM criteria by default #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmadalin
force-pushed
the
feature/daemon-toolchain-wizard-default
branch
from
34ef2f6 to
51f3c63
Compare
vmadalin
force-pushed
the
feature/daemon-toolchain-wizard-default
branch
from
51f3c63 to
f27aba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
Daemon toolchainwas introduced in Gradle 8.8 and the motivation behind it and other technical details can be found on the public spec document. The implementation follows the agreed details on spec document and UI/UX document.Summary
When creating a new project via wizard, in case of using a Gradle version compatible with
Daemon JVM criteriathen specified JDK from the dropdown will be used to invokeupdateDaemonJvmGradle task with the resolvedversionandvendorfrom JDK. The vendor will only be specified if is known by foojay-plugin being able to generate the different toolchain download URLs for theauto-provisioningmechanism.NOTE: For now this option will be disabled until
Daemon JVM criteriasupports theauto-provisioningbut also until the feature is stable enough to be considered as a default for projects, keeping it as a opt-in option.NOTE: This PR was build on top of #2882 to avoid conflicts.
Tasks
Tests
Demo
Screen.Recording.2024-11-29.at.15.05.35.mov