Allow the user to set order of prefixes #2892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation used HashSet which sorts prefixes by their hash, and empty string "" was put before probably any other prefix (at least before very common "_"). When it was before, it matched first and underscore never matched so it was not possible to automatically remove _ prefixes from property names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation used HashSet which sorts prefixes by their hash, and empty string "" was put before probably any other prefix (at least before very common "_"). Then, it matched first and underscore never matched so it was not possible to automatically remove _ prefixes from property names.
There is a need to include this empty string if you want prefixes only for underscore prefix removal and not for filtering properties.
This will allow workaround for this bug: IDEA-363722