Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement/fix/complete implementation of scrollbars #554

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Reimplement/fix/complete implementation of scrollbars #554

merged 14 commits into from
Aug 26, 2024

Commits on Aug 23, 2024

  1. Fix Scrollbars [part 1/n] 

    * Implement TrackClickBehaviors correctly
* Fix macOS scrollbar styling
* Provide ScrollableContainers for a simple, turn-key scrollbar API
* Make expanded scrollbar not hide while the mouse moves over the
  scrollable composable
* Fix the expanding behaviour and animation on macOS
* Fix the visibility logic on macOS
* Resolve a number of inconsistencies with Swing implementations
* Simplify and consolidate internal implementation
* Separate tabStrip scrollbar styling
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3c5417f View commit details
    Browse the repository at this point in the history

  2. Fix Scrollbars [part 2/n] 

    * Fix thumb colour fade in AlwaysVisible mode
* Move sample border to Outside so it doesn't overlap the scrollbar
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    95c0727 View commit details
    Browse the repository at this point in the history

  3. Fix Scrollbars [part 4/n] 

    * Rework layout/draw logic to finally align with Swing, in dark mode too
* Switch to custom drawing for the thumb for more control
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ad7ba0b View commit details
    Browse the repository at this point in the history

  4. Fix Scrollbars [part 5/n] 

    * Cleanup code
* Update API definitions
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0a6f50b View commit details
    Browse the repository at this point in the history

  5. Fix Scrollbars [part 6/n] 

    * Make bridge compile
* Fix styling in bridge
* Update bridge samples
* Fix TextArea scrollbars
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1cac4a1 View commit details
    Browse the repository at this point in the history

  6. Fix Scrollbars [part 7/n] 

    * Fix bug in ScrollableContainer
* Improve ReleasesSampleCompose
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    71ba3e1 View commit details
    Browse the repository at this point in the history

  7. Fix Scrollbars [part 8/n] 

    * Rewrite MacScrollbarHelper to avoid native crashes
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b8e49ff View commit details
    Browse the repository at this point in the history

  8. Fix Scrollbars [part 10/n] 

    * Add decorationModifier to TextArea API (useful e.g., for padding when
  there are scrollbars)
* Fix ScrollableContainerImpl layout logic and bugs
* Fix one HorizontallyScrollableContainer using vScroll by mistake
* Use HorizontallyScrollableContainer in Markdown block renderer
* Update standalone sample Markdown with new APIs
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b2b56e6 View commit details
    Browse the repository at this point in the history

  9. Fix Scrollbars [part 11/n] 

    * Add mouse move linger behaviour to all ScrollableContainers
* Add horizontal scrolling example to standalone sample
* Fix ScrollableContainerImpl layout bug with WhenScrolling
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9241db4 View commit details
    Browse the repository at this point in the history

  10. Fix Scrollbars [part 12/n] 

    * Remove debug bg from Scrollbars sample
* Fix thumb appearing/disappearing animation
* Fix colour animations
* Keep AlwaysVisible thumb "hovered" while dragging
* Fix styling in the bridge
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d2fbfc1 View commit details
    Browse the repository at this point in the history

  11. Fix Scrollbars [part 13/n] 

    * Fix InputField ignoring provided scrollbar style
* Remove useless KDocs from TextArea/TextField
* Clean up code
* Mark non-state-based TextArea/TextField as scheduled for removal
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    beb2797 View commit details
    Browse the repository at this point in the history

  12. Fix Scrollbars [part 14/n] 

    * Fix native crash when TextField/TextArea don't have a fixed width
* Redo the entire BTF2-based InputField implementation, better
* Expose all the new parameters that BTF2-based InputField has to the
  users of TextField and TextArea
* Fix TextArea decoration and scrollbars
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e66de7b View commit details
    Browse the repository at this point in the history

  13. Fix Scrollbars [part 15/n] 

    * Fix scrollbars on Windows and Linux
* Fix TextArea end padding to account for scrollbar
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    31d1b98 View commit details
    Browse the repository at this point in the history

  14. Fix Scrollbars [part 16/16] 

    * Clean up code
* Add scrollbar to undecorated TextAreas
    @rock3r
    rock3r committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    67947ce View commit details
    Browse the repository at this point in the history