Add JS and Wasm for 2.0.x version #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoobestik
force-pushed
the
fix-browser-platforms
branch
from
3b4f2ab
to
57a235c
Compare
zoobestik
commented
Dec 19, 2023
| @@ -20,7 +20,7 @@ | |||
| "@babel/plugin-transform-runtime": "~7.22.4", | |||
| "@babel/preset-env": "~7.22.4", | |||
| "@babel/runtime-corejs2": "~7.22.2", | |||
| "@playwright/test": "^1.37.1", | |||
| "@playwright/test": "^1.40.1", | |||
There was a problem hiding this comment.
It's required for Wasm test in chrome with enabled WasmGC.
| if (!isKeyOfObject(target, TargetPlatforms)) | ||
| throw new Error('Invalid target platform'); | ||
|
|
||
| options.targetPlatform && getTargetById(options.targetPlatform); |
There was a problem hiding this comment.
It's real bug - it's impossible to pass js-ir platform. Cause expected js_ir.
Test below.
|
|
||
| if (platform === TargetPlatforms.JS_IR && minor < MINIMAL_MINOR_VERSION_IR) { |
There was a problem hiding this comment.
Main issue 2.0.0 has minor less then 5 or 9.
| @@ -30,7 +30,9 @@ function isRunRequest(url: URL | string) { | |||
|
|
|||
| return ( | |||
| uri.host === API_HOST && | |||
| uri.pathname.match(/^\/?\/api\/\d+\.\d+\.\d+\/compiler\/run$/) !== null | |||
| (uri.pathname.match(/^\/?\/api\/\d+\.\d+\.\d+\/compiler\/run$/) !== null || | |||
| uri.pathname.match(/^\/?\/api\/\d+\.\d+\.\d+\/compiler\/translate$/) !== | |||
There was a problem hiding this comment.
Catch for both types of targets.
nikpachoo
approved these changes
Dec 19, 2023
zoobestik
force-pushed
the
fix-browser-platforms
branch
3 times, most recently
from
c5308ff
to
800bf4a
Compare
zoobestik
force-pushed
the
fix-browser-platforms
branch
from
800bf4a
to
54a2ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues:
✅ Fix for passing
data-target-platform=js-ir✅ Accept JS_IR for 2.0.x
Chore:
⚠️ update playwright deps.
Add tests:
➕ Platforms restrictions › JS_IR for unsupported version
➕ Platforms restrictions › JS_IR for supported by minor version
➕ Platforms restrictions › JS_IR for supported by major version
➕ Platforms restrictions › WASM for unsupported version
➕ Platforms restrictions › WASM for supported by minor version [chromium only]
➕ Platforms restrictions › WASM for supported by major version [chromium only]