Support streaming output #84
Conversation
|
@lyubortk @zoobestik Let's use streaming if the attribute |
| applyStateUpdate(stateUpdate) { | ||
| if (stateUpdate.errors === null) { | ||
| stateUpdate.errors = [] | ||
| } else if (stateUpdate.errors !== undefined) { |
There was a problem hiding this comment.
We can do it after filter and code should be simpler after that.
There was a problem hiding this comment.
Well, I placed this peace of code after filtration but could not come up with any idea how to make it simpler. We must distinguish null here because passing null as stateUpdate.errors tells the function to remove previous errors in the state. Therefore if is necessary here.
| `Please click <a href=http://kotl.in/issue target=_blank>here<a> to submit it ` + | ||
| const BUG_FLAG = 'BUG' | ||
| const BUG_REPORT_MESSAGE = 'Hey! It seems you just found a bug! \uD83D\uDC1E\n' + | ||
| `Please go here -> http://kotl.in/issue to submit it ` + |
There was a problem hiding this comment.
What is happened with link? :(
There was a problem hiding this comment.
Merging DOM nodes turns into text all inner elements so the link will not be clickable.
I thought that this case with BUG_FLAG is too rare and not really important to add specific behaviour for it.
Is it possible to merge nodes without destroying children?
src/view/output-view.js
Outdated
| return `<div class="test-time">Total test time: ${testResults.totalTime}s</div>` | ||
| } | ||
|
|
||
| export function processJUnitTestResult(testRunInfo, testResults) { |
There was a problem hiding this comment.
@lyubortk actually i don't understand what is happend with test output. Can you explain me differences in this output. It's too much changes not clear for me :(
There was a problem hiding this comment.
I had to rewrite that because each test result must be handled separately with streaming.
|
@AlexanderPrendota i'm still don't understand why do we need |
|
I returned synchronous mode back and added |
|
I also added some handling of HTTP error codes and failed requests for streaming (I print a message as |
No description provided.