Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: move Hands-on start page to the Kotlin docs #3578

Merged
merged 5 commits into from
Aug 25, 2023
Merged

update: move Hands-on start page to the Kotlin docs #3578

merged 5 commits into from
Aug 25, 2023

Conversation

koshachy
Copy link
Member

@koshachy koshachy commented May 16, 2023 •
edited
Loading

@koshachy
Copy link
Member Author

@nikpachoo Please ping me when you will be ready to merge redirects

@github-actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 23, 2023
@koshachy koshachy removed the Stale label Jun 29, 2023
@github-actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 30, 2023
@nikpachoo nikpachoo removed the Stale label Jul 31, 2023
sarahhaggarty
sarahhaggarty approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! i've made some suggestions to make the introductions look more uniform but it's up to you.

docs/topics/kotlin-hands-on.md Outdated Show resolved Hide resolved
docs/topics/kotlin-hands-on.md Outdated Show resolved Hide resolved
docs/topics/kotlin-hands-on.md Outdated Show resolved Hide resolved
@nikpachoo nikpachoo requested review from nikpachoo and removed request for dromanov-jb August 24, 2023 09:45
@koshachy koshachy requested a review from a team as a code owner August 25, 2023 11:10
@koshachy koshachy merged commit f130f58 into master Aug 25, 2023
3 checks passed
@koshachy koshachy deleted the move-hands-ons-to-docs branch August 25, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danil-pavlov danil-pavlov danil-pavlov approved these changes

@sarahhaggarty sarahhaggarty sarahhaggarty approved these changes

@nikpachoo nikpachoo Awaiting requested review from nikpachoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koshachy @sarahhaggarty @danil-pavlov @nikpachoo