Fix basePackage value for "Build a full-stack web app with Kotlin Multiplatform" tutorial #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiplatform" tutorial I am currently going through the tutorial but found an issue when I reached the [Serve HTML and JavaScript files from Ktor](https://kotlinlang.org/docs/multiplatform-full-stack-app.html#serve-html-and-javascript-files-from-ktor) part. In my case, I was facing a 404 error when running the app for `shoppinglist.js` file. <img width="1444" alt="image" src="https://github.com/kuroski/js-to-jsx/assets/1855125/f7dc6ab8-5475-494c-a19e-c7ddf95b82ec"> After some trials and errors, I finally found that the issue was that the `basePackage` property from `Ktor` should actually be empty ``` staticResources("/", "") ``` <img width="1847" alt="image" src="https://github.com/kuroski/js-to-jsx/assets/1855125/339be57f-35b2-48d4-b341-73a92a5dbb97">
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Daniel, thank you for the report, and I'm sorry it took so long. We discuused this issue with developers and decided to take a different approach to solve this issue. Please see #3764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently going through the tutorial for "Build a full-stack web app with Kotlin Multiplatform" but found an issue when I reached the "Serve HTML and JavaScript files from Ktor" part.
In my case, I was facing a 404 error when running the app for
shoppinglist.jsfile.After some trials and errors, I finally found that the issue was that the
basePackageproperty fromKtorshould actually be empty