-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small update to Type checks and casts page #3710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update! I'm just wondering why you opted for an xml table instead of Markdown? We usually try to use md syntax because it's more readable except for special cases when it's not enough
Is it because of the necessary table header in md tables? You can still add something like Element | Condition at the top of the table
a7f1517
to
cf44362
Compare
Thanks @danil-pavlov ! Yes, it's because I wanted to use a table without a header, which is only possible via XML right now. Originally this was just a bulleted list but I think it is easier to read in a table format. I couldn't find header names that I liked unfortunately. Even "element" doesn't seem relevant enough to me for the first column 🤔 Is it OK to stick with the XML or could you help me find better header names? |
I like the table idea and I can't come up with anything better than "Variables and properties", so let's keep the XML table as is |
cf44362
to
0d3b4a8
Compare
This PR updates the Type checks and casts page to make it clear earlier in the page that generics documentation is available on another page. Other changes have been added, like an introduction and other modifications, to tidy up the page a bit.
This PR resolves KT-57270.