feat: using platform-specific apis #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahhaggarty
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Looking good @danil-pavlov!
I mostly have minor comments. There are two things I consistently changed:
- "expected/actual mechanism" -> "expected and actual declarations". I think this is clearer for the reader.
- The "correct" implementation -> The "right" or "relevant" implementation. "Correct" makes it sound like there are incorrect implementations. This could just be a nit from me as a native speaker though.
sarahhaggarty
approved these changes
Oct 12, 2023
danil-pavlov
requested review from
zoobestik,
nikpachoo and
krutilov
as code owners
danil-pavlov
force-pushed
the
kmp-connect-apis
branch
2 times, most recently
from
9d5e845
to
1c70755
Compare
danil-pavlov
force-pushed
the
kmp-connect-apis
branch
from
1c70755
to
563df81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.