Update the tutorial build scripts with 1.9.20 APIs #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulowork
commented
Oct 11, 2023
| the SQLDelight versions of the plugin and the libraries are the same: | ||
|
|
||
| ```none | ||
| sqlDelightVersion=%sqlDelightVersion% |
There was a problem hiding this comment.
I couldn't find a reference to this property anywhere. Could it have been left by accident from an earlier tutorial revision or did I miss something?
There was a problem hiding this comment.
Yes, I guess it's something old. If it's not used in the sample project, we can remove it
abdulowork
commented
Oct 11, 2023
|
|
||
| dependencies { | ||
| // ... | ||
| classpath("com.squareup.sqldelight:gradle-plugin:%sqlDelightVersion%") |
There was a problem hiding this comment.
Is there any reason to specify buildscript dependencies explicitly? I think the explicit version in the plugins block achieves the same goal
There was a problem hiding this comment.
I agree, looks better. If it's not used in the sample project, we can remove it
This was referenced Oct 11, 2023
danil-pavlov
requested review from
MKrishtal,
zoobestik,
nikpachoo and
krutilov
as code owners
danil-pavlov
removed request for
zoobestik,
nikpachoo,
krutilov and
MKrishtal
danil-pavlov
approved these changes
Oct 13, 2023
abdulowork
force-pushed
the
prepare-samples-for-1.9.20
branch
from
dbdc7da
to
7f08109
Compare
koshachy
pushed a commit
that referenced
this pull request
Oct 27, 2023
Co-authored-by: Timofey Solonin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates this tutorial with 1.9.20 build script APIs. The corresponding updates in the sample: