update: forward declarations in c and objc #4477
Conversation
| @@ -914,7 +914,7 @@ Here's the planned deprecation cycle: | |||
| **What's changed?** | |||
|
|
|||
| The JetBrains team has revamped the approach to forward declarations in Kotlin to make their behavior more predictable | |||
| and prepare this functionality for the upcoming Kotlin 2.0 release. From now on: | |||
| and prepare this functionality for the Kotlin 2.0.0 release. From now on: | |||
There was a problem hiding this comment.
Do we need this line about Kotlin 2.0.0? In my opinion, the following line is more than enough:
"The JetBrains team has revamped the approach to forward declarations in Kotlin to make their behavior more predictable:"
| > Otherwise, you'll get an error. | ||
| > | ||
| {style="note"} | ||
| * Consider two objcinterop libraries, one that uses `objcnames.protocols.ForwardDeclaredProtocolProtocol` and the other |
There was a problem hiding this comment.
| * Consider two objcinterop libraries, one that uses `objcnames.protocols.ForwardDeclaredProtocolProtocol` and the other | |
| * Consider two objcinterop libraries: one that uses `objcnames.protocols.ForwardDeclaredProtocolProtocol` and another |
| } | ||
| ``` | ||
|
|
||
| > The casting to `objcnames.protocols.ForwardDeclaredProtocolProtocol` is only allowed from the corresponding real class. |
There was a problem hiding this comment.
Maybe it is better to get rid of the passive voice here:
You can only cast to objcnames.protocols.ForwardDeclaredProtocolProtocol from the corresponding real class. Otherwise, you'll get an error.
There was a problem hiding this comment.
If you'd like to keep the original sentence, the first "The" article is not needed.
| `import cnames.structs.cstructName`. | ||
|
|
||
| Consider two cinterop libraries, one that has a forward declaration of a struct and the other |
| ``` | ||
|
|
||
| To transfer objects between the two libraries, make the `as` cast in you Kotlin code: |
There was a problem hiding this comment.
| To transfer objects between the two libraries, make the `as` cast in you Kotlin code: | |
| To transfer objects between the two libraries, use the `as` cast in you Kotlin code: |
| @@ -228,7 +228,11 @@ A Swift/Objective-C initializer is imported to Kotlin as constructors or as fact | |||
| The latter happens with initializers declared in the Objective-C category or as a Swift extension, | |||
| because Kotlin has no concept of extension constructors. | |||
|
|
|||
| Kotlin constructors are imported as initializers to Swift/Objective-C. | |||
| > Remember to annotate Swift initializers with `@objc` before importing them to Kotlin. | |||
There was a problem hiding this comment.
Is this a recommendation or a mandatory action?
If the latter, we can omit the "Remember" word:
Annotate Swfit initializers ...
or
"Before importing Swift initializers to Kotlin, add the @objc annotation to them"
There was a problem hiding this comment.
No, here is just a reminder of something stated above. Some people skip it, so we decided to add a note in this section too
| to import a `objcprotocolName` forward declaration declared in an Objective-C library with a `library.package`, | ||
| use a special forward declaration package: `import objcnames.protocols.objcprotocolName`. | ||
|
|
||
| Consider two objcinterop libraries, one that uses `objcnames.protocols.ForwardDeclaredProtocolProtocol` |
| } | ||
| ``` | ||
|
|
||
| > The casting to `objcnames.protocols.ForwardDeclaredProtocolProtocol` is only allowed from the corresponding real class. |
No description provided.