API for the general-purpose model checker #411
Conversation
|
@dmitrii-artuhov thanks for the PR. |
dmitrii-artuhov
changed the title
ndkoval
changed the title
| ), | ||
| emptyList(), | ||
| null | ||
| ) |
There was a problem hiding this comment.
Please use CustomScenarioDSL.kt instead.
|
|
||
| val result = strategy.runInvocation() | ||
| val failure = strategy.verify(result, verifier) | ||
|
|
There was a problem hiding this comment.
Why so many empty lines for just a few lines of code ?)
| } | ||
|
|
||
| return null | ||
| } |
There was a problem hiding this comment.
Please add tests for this function.
For start, add few tests in representation sub-module and check that the trace is correctly collected.
| private class ExecutionExceptionsVerifier(@Suppress("UNUSED_PARAMETER") sequentialSpecification: Class<*>) : Verifier { | ||
| override fun verifyResults(scenario: ExecutionScenario?, results: ExecutionResult?): Boolean { | ||
| if (results == null) return true | ||
| // User `check(...)`'s will fail and put their exceptions as an execution result, we must track that and disallow such outcomes. |
There was a problem hiding this comment.
Please move this explanation to the kdoc of ExecutionExceptionsVerifier.
dmitrii-artuhov
force-pushed
the
run-with-lincheck-api
branch
from
9e0d1fa to
426aa8a
Compare
| * @param invocations number of different interleavings of code in the [block] | ||
| * that should be explored. | ||
| * @param block lambda which body will be a target for the interleavings exploration. | ||
| */ |
There was a problem hiding this comment.
/**
* This method will explore different interleavings of the [block] body and all the threads created within it, searching for the first raised exception.
*
* @param invocations number of different interleavings of code in the [block] that should be explored.
* @param block lambda which body will be a target for the interleavings exploration.
*/| @@ -48,6 +48,8 @@ abstract class CTestConfiguration( | |||
| stateRepresentationMethod: Method? | |||
| ): Strategy | |||
|
|
|||
| fun createVerifier() = verifierClass.getConstructor(Class::class.java).newInstance(sequentialSpecification) | |||
There was a problem hiding this comment.
Please make this an extension function, as it was before.
| @JvmStatic | ||
| fun <R> verifyWithModelChecker( | ||
| invocations: Int = ManagedCTestConfiguration.DEFAULT_INVOCATIONS, | ||
| verifierClass: Class<out Verifier>? = null, |
There was a problem hiding this comment.
Let's not expose the verifier in the API of this function.
| import java.util.concurrent.atomic.AtomicReference | ||
| import java.util.concurrent.atomic.AtomicReferenceArray | ||
|
|
||
| class AtomicReferencesNamesRunWithLambdaTests : BaseRunWithLambdaRepresentationTest("atomic_references_names_trace_run_with_lambda.txt") { |
There was a problem hiding this comment.
please shorten the names of the .txt files
| * Implement me and place the logic to check its trace. | ||
| */ | ||
| @Operation | ||
| abstract fun operation() |
There was a problem hiding this comment.
Let's rename to block. Also, you don't need @Operation annotation for this new API.
| } | ||
| failure.checkLincheckOutput(outputFileName) | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's put all the new tests together into singe file RunWithLambdaRepresentationTests.
No description provided.