Skip to content

Commit

Permalink
[phpstorm-stubs] remove redundant typehints and PHPDocs
Browse files Browse the repository at this point in the history
  • Loading branch information
isfedorov committed Aug 28, 2023
1 parent d3ad022 commit beac237
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 34 deletions.
25 changes: 3 additions & 22 deletions dom/dom_c.php
Original file line number Diff line number Diff line change
Expand Up @@ -318,35 +318,16 @@ public function lookupNamespaceURI(?string $prefix): ?string {}
public function lookupNamespaceUri($prefix) {}

/**
* @param DOMNode $arg
* @param DOMNode|null $arg
* @return bool
* @removed 8.0
*/
public function isEqualNode(DOMNode $arg) {}
#[LanguageLevelTypeAware(['8.3' => 'bool'], default: '')]
public function isEqualNode(#[LanguageLevelTypeAware(['8.3' => 'DOMNode|null'], default: 'DOMNode')] $otherNode) {}

/**
* @since 8.3
*/
public function isEqualNode(?DOMNode $otherNode): bool {}

/**
* @param $feature
* @param $version
* @return mixed
*/
public function getFeature($feature, $version) {}

/**
* @param $key
* @param $data
* @param $handler
*/
public function setUserData($key, $data, $handler) {}

/**
* @param $key
* @return mixed
*/
public function getUserData($key) {}

/**
Expand Down
24 changes: 12 additions & 12 deletions standard/standard_8.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function syslog(int $priority, string $message): bool {}
function syslog(int $priority, string $message) {}

/**
* Close connection to system logger
* @link https://php.net/manual/en/function.closelog.php
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function closelog(): bool {}
function closelog() {}

/**
* Registers a function that will be called when PHP starts sending output.
Expand Down Expand Up @@ -395,7 +395,7 @@ function ob_list_handlers(): array {}
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function ksort(array &$array, int $flags = SORT_REGULAR): bool {}
function ksort(array &$array, int $flags = SORT_REGULAR) {}

/**
* Sort an array by key in reverse order
Expand All @@ -410,7 +410,7 @@ function ksort(array &$array, int $flags = SORT_REGULAR): bool {}
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function krsort(array &$array, int $flags = SORT_REGULAR): bool {}
function krsort(array &$array, int $flags = SORT_REGULAR) {}

/**
* Sort an array using a "natural order" algorithm
Expand Down Expand Up @@ -460,7 +460,7 @@ function asort(array &$array, int $flags = SORT_REGULAR) {}
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function arsort(array &$array, int $flags = SORT_REGULAR): bool {}
function arsort(array &$array, int $flags = SORT_REGULAR) {}

/**
* Sort an array
Expand All @@ -478,7 +478,7 @@ function arsort(array &$array, int $flags = SORT_REGULAR): bool {}
* (don't change types)</p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function sort(array &$array, int $flags = SORT_REGULAR): bool {}
function sort(array &$array, int $flags = SORT_REGULAR) {}

/**
* Sort an array in reverse order
Expand Down Expand Up @@ -508,7 +508,7 @@ function rsort(array &$array, int $flags = SORT_REGULAR) {}
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function usort(array &$array, callable $callback): bool {}
function usort(array &$array, callable $callback) {}

/**
* Sort an array with a user-defined comparison function and maintain index association
Expand All @@ -522,7 +522,7 @@ function usort(array &$array, callable $callback): bool {}
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function uasort(array &$array, callable $callback): bool {}
function uasort(array &$array, callable $callback) {}

/**
* Sort an array by keys using a user-defined comparison function
Expand All @@ -543,7 +543,7 @@ function uasort(array &$array, callable $callback): bool {}
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function uksort(array &$array, callable $callback): bool {}
function uksort(array &$array, callable $callback) {}

/**
* Shuffle an array
Expand All @@ -553,7 +553,7 @@ function uksort(array &$array, callable $callback): bool {}
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function shuffle(array &$array): bool {}
function shuffle(array &$array) {}

/**
* Apply a user function to every member of an array
Expand Down Expand Up @@ -587,7 +587,7 @@ function shuffle(array &$array): bool {}
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function array_walk(object|array &$array, callable $callback, mixed $arg): bool {}
function array_walk(object|array &$array, callable $callback, mixed $arg) {}

/**
* Apply a user function recursively to every member of an array
Expand Down Expand Up @@ -615,7 +615,7 @@ function array_walk(object|array &$array, callable $callback, mixed $arg): bool
* </p>
*/
#[LanguageLevelTypeAware(['8.2' => 'true'], default: 'bool')]
function array_walk_recursive(object|array &$array, callable $callback, mixed $arg): bool {}
function array_walk_recursive(object|array &$array, callable $callback, mixed $arg) {}

/**
* Counts all elements in an array, or something in an object.
Expand Down

0 comments on commit beac237

Please sign in to comment.