Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WI-73896: Fix T_BAD_CHARACTER annotation #1563

Merged
merged 1 commit into from
Aug 23, 2023
Merged

WI-73896: Fix T_BAD_CHARACTER annotation #1563

merged 1 commit into from
Aug 23, 2023

Conversation

lkrms
Copy link
Contributor

@lkrms lkrms commented Aug 12, 2023

No description provided.

@LolGleb
Copy link
Contributor

LolGleb commented Aug 16, 2023

Could you please completely remove the PHPDoc? T_BAD_CHARACTER token previously already existed in PHP, but was removed in PHP 7.0. After that it was reintroduced in PHP 7.4. So saying that it is only available since 7.4 not entirely correct.

LolGleb
LolGleb requested changes Aug 17, 2023
View reviewed changes
tokenizer/tokenizer.php Outdated Show resolved Hide resolved
@lkrms
Copy link
Contributor Author

lkrms commented Aug 23, 2023

Apologies for the delay, I've made the requested change and rebased.

@LolGleb LolGleb merged commit 76e6d9d into JetBrains:master Aug 23, 2023
10 checks passed
@lkrms lkrms deleted the fix/t_bad_character branch August 23, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LolGleb LolGleb LolGleb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkrms @LolGleb