Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis stub from an very outdated version to the latest stable version (6.0.2) #1648

Closed
wants to merge 2 commits into from

Conversation

karstennilsen
Copy link

The redis stub contains:

@link https://github.com/phpredis/phpredis/blob/develop/redis.stub.php

But the stub itself was not even close to similar / up to date with the linked version.
This is causing unexpected situations where e.g. the ttl() method in reality returns -2 when a key is not found but the old stub from this project specified false.

@karstennilsen
Copy link
Author

FYI: https://redis.io/docs/latest/commands/ttl/ states In Redis 2.6 or older the command returns -1 if the key does not exist or if the key exist but has no associated expire.

So the current stub is referencing an implementation of Redis 2.6 or older. Redis 2.6 last release was in 2013. You can't even find it anymore in the Redis.com download archive.

@isfedorov
Copy link
Contributor

Manually pushed at 1ff6208

@isfedorov isfedorov closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants