feat(caddy): persist replay cache across config reloads #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r proxy protocol.
sbruens
changed the title
fortuna
requested changes
Sep 19, 2024
sbruens
force-pushed
the
sbruens/replaycache
branch
2 times, most recently
from
43318e7
to
9de7a6a
Compare
sbruens
force-pushed
the
sbruens/replaycache
branch
from
9de7a6a
to
d435603
Compare
|
Picking this up again. PTAL @fortuna |
fortuna
reviewed
Oct 7, 2024
service/replay.go
Outdated
| // archive. | ||
| func (c *ReplayCache) Resize(capacity int) { | ||
| if capacity > MaxCapacity { | ||
| panic("ReplayCache capacity would result in too many false positives") |
There was a problem hiding this comment.
Please return an error and handle it instead of crashing the server. Config updates shouldn't crash the server (perhaps log error and keep the old config).
There was a problem hiding this comment.
I did this to mimic the constructor's behavior. Do you want me to update it there as well or leave that one alone, since that's more likely to be called on startup by a caller?
fortuna
approved these changes
Oct 7, 2024
sbruens
force-pushed
the
sbruens/replaycache
branch
from
fe8d6ca
to
8209056
Compare
sbruens
commented
Oct 7, 2024
| @@ -92,11 +93,25 @@ func (c *ReplayCache) Add(id string, salt []byte) bool { | |||
| return false | |||
| } | |||
| _, inArchive := c.archive[hash] | |||
| if len(c.active) == c.capacity { | |||
| if len(c.active) >= c.capacity { | |||
There was a problem hiding this comment.
@fortuna I already merged a bit too fast, but just wanted to point out this specific change I made as part of not actively shrinking the maps in the Resize() method. This is needed, otherwise we'll never shrink maps that were resized down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the replay history config could be changed, this introduces a way to resize the
ReplayCachein case the capacity needs to shrink.