Fix TZDB compiler %z parsing

[jodastephen]

• Needs to take account of standard millis

Summary by CodeRabbit

• New Features

  • Enhanced handling of time zone rules for improved accuracy in standard and daylight saving time calculations.
  • Introduced a new test for the "Atlantic/Azores" time zone to validate specific date behaviours.

• Bug Fixes

  • Updated time zone name formatting to reflect changes in time zone calculations, ensuring accurate outputs across various scenarios.

• Tests

  • Modified existing tests to align with the updated time zone handling and added new tests to enhance overall coverage.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve modifications to the Rule class within the ZoneInfoCompiler.java file, specifically updating the addRecurring and formatName methods. The addRecurring method's signature has been changed to include an additional standardMillis parameter, while the formatName method has been enhanced to handle this new parameter. Corresponding updates have been made to the TestCompiler.java file to reflect these changes in the test cases, including the introduction of a new test method for the "Atlantic/Azores" time zone.

Changes

Files	Change Summary
src/main/java/org/joda/time/tz/ZoneInfoCompiler.java	- Modified addRecurring method to include standardMillis parameter. - Updated formatName method to accept standardMillis, enhancing its functionality for time zone calculations.
src/test/java/org/joda/time/tz/TestCompiler.java	- Updated test_formatName method to reflect changes in formatName method. - Added new test method test_Azores to validate time zone behaviour for the "Atlantic/Azores" region, improving test coverage for time zone functionality.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2f2ecf3 and 8c38a6a.

Files selected for processing (2)

• src/main/java/org/joda/time/tz/ZoneInfoCompiler.java (5 hunks)
• src/test/java/org/joda/time/tz/TestCompiler.java (2 hunks)

Files skipped from review as they are similar to previous changes (2)

• src/main/java/org/joda/time/tz/ZoneInfoCompiler.java
• src/test/java/org/joda/time/tz/TestCompiler.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.