Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MomentaryFix for future signature error #65

Merged
merged 1 commit into from
Jul 28, 2023
Merged

MomentaryFix for future signature error #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions R/class-auth.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,14 +280,14 @@ FirebaseAuth <- R6::R6Class(
now <- as.numeric(Sys.time() + private$.grace_period)

if(as.numeric(signature$exp) < now){
cli_alert_danger("Signture expiry is in the past")
cli_alert_danger("Signature expiry is in the past")
return(FALSE)
}

if(as.numeric(signature$iat) > now){
cli_alert_danger("Signture issued at time is in the future")
return(FALSE)
}
# if(as.numeric(signature$iat) > now){
# cli_alert_danger("Signature issued at time is in the future")
# return(FALSE)
# }

if(signature$aud != super$get_project_id()){
cli_alert_danger("Signature audience is not the project id")
Expand All @@ -309,10 +309,10 @@ FirebaseAuth <- R6::R6Class(
return(FALSE)
}

if(signature$auth_time > now){
cli_alert_danger("Signature auth time is in the future")
return(FALSE)
}
# if(signature$auth_time > now){
# cli_alert_danger("Signature auth time is in the future")
# return(FALSE)
# }

return(TRUE)
},
Expand Down
Loading