fix: return value in Roblox platform notification handler (#910)

* fix: return value in Roblox platform notification handler * fix: allow multiple workspaces to handle notifications
JohnnyMorganz · Feb 1, 2025 · 50e305b · 50e305b
1 parent e6c6413
commit 50e305b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/LanguageServer.cpp b/src/LanguageServer.cpp
@@ -339,13 +339,15 @@ void LanguageServer::onNotification(const std::string& method, std::optional<jso
     }
     else
     {
+        bool handled = false;
         for (auto& workspace : workspaceFolders)
         {
             if (workspace->platform && workspace->platform->handleNotification(method, params))
-                return;
+                handled = true;
         }
 
-        client->sendLogMessage(lsp::MessageType::Warning, "unknown notification method: " + method);
+        if (!handled)
+            client->sendLogMessage(lsp::MessageType::Warning, "unknown notification method: " + method);
     }
 }
 

diff --git a/src/platform/roblox/RobloxStudioPlugin.cpp b/src/platform/roblox/RobloxStudioPlugin.cpp
@@ -30,10 +30,12 @@ bool RobloxPlatform::handleNotification(const std::string& method, std::optional
     if (method == "$/plugin/full")
     {
         onStudioPluginFullChange(JSON_REQUIRED_PARAMS(params, "$/plugin/full"));
+        return true;
     }
     else if (method == "$/plugin/clear")
     {
         onStudioPluginClear();
+        return true;
     }
 
     return false;