Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better memory allocation #32

Merged
merged 15 commits into from
Dec 27, 2024
Merged

Better memory allocation #32

merged 15 commits into from
Dec 27, 2024

Conversation

JonathSpirit
Copy link
Owner

Move CreateImage() CreateBuffer() to Context class:

  • Avoid hardcoding VMA flags
    • Most notable change is that buffer don't use anymore the VMA_ALLOCATION_CREATE_MAPPED_BIT
  • Use VMA_MEMORY_USAGE_AUTO instead of unknown
  • Apply this change to codebase

VertexBuffer DEVICE mode:

  • Use indirect command buffer execution

Add missing VK_EXT_ROBUSTNESS_2_EXTENSION_NAME.

Shaders: add missing "readonly" decoration

  • This mute validation error : "vertexPipelineStoresAndAtomics was not enabled."

Move CreateImageView() to LogicalDevice

@JonathSpirit
vulkanGlobal: add BufferInfo struct, and deprecate CreateBuffer
3e64e0b
@JonathSpirit
vulkanGlobal: add missing VK_EXT_ROBUSTNESS_2_EXTENSION_NAME
7c1f797
@JonathSpirit
Context: add createBuffer()
e9a7878 
Diff with old CreateBuffer():
- VmaAllocationCreateFlags flags in argument for better control
- Return an optional std::optional<BufferInfo>, (don't throw)
- Set usage as VMA_MEMORY_USAGE_AUTO instead of unknown
@JonathSpirit
VertexBuffer: use Context::createBuffer() in LOCAL mode
4bb5903 
- This also remove the unneeded VMA_ALLOCATION_CREATE_MAPPED_BIT flag (a small boost in FPS remarked)
- VMA_ALLOCATION_CREATE_MAPPED_BIT: permanent mapping, but code is "mapping -> copy -> unmapping"
@JonathSpirit
GarbageCollector: add GarbageBuffer constructor with BufferInfo
ca5a7d9
@JonathSpirit
VertexBuffer: use Context::createBuffer() for DEVICE mode, use INDIRE…
055809a 
…CT_EXECUTION for submit type
@JonathSpirit
TextureImage: remove usage of CreateBuffer()
2b95cba
@JonathSpirit
Shaders: add missing "readonly" decoration
5d29b89 
- This mute validation error : "vertexPipelineStoresAndAtomics was not enabled."
@JonathSpirit
ObjSpriteBatches: avoid passing by requestGlobalTransform()
02f6fa7
@JonathSpirit
UniformBuffer: apply Context::createBuffer()
e796f04
@JonathSpirit
IndexBuffer: apply Context::createBuffer()
ddede11
@JonathSpirit
remove deprecated
a7b05b7
@JonathSpirit
Context: add createImage()
4713369
@JonathSpirit
vulkanGlobal: add ImageInfo, apply Context::createImage to TextureImage
7852288
@JonathSpirit
vulkanGlobal: move CreateImageView() to LogicalDevice
b27a6ad
@JonathSpirit JonathSpirit added this to the v0.9.4 milestone Dec 27, 2024
@JonathSpirit JonathSpirit self-assigned this Dec 27, 2024
@JonathSpirit JonathSpirit merged commit e0b8518 into master Dec 27, 2024
12 checks passed
@JonathSpirit JonathSpirit deleted the BetterMemoryAllocation branch December 27, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JonathSpirit JonathSpirit

Labels
None yet
Projects
None yet
Milestone
v0.9.4
Development

Successfully merging this pull request may close these issues.
1 participant
@JonathSpirit