Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Docker build #183

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor: Docker build #183

wants to merge 8 commits into from

Conversation

Dashboy1998
Copy link

@Dashboy1998 Dashboy1998 commented Jul 27, 2024 •
edited
Loading

  • Mreged docker files into one file.
    • Not entirely sure I made the correct changes in .github/workflows/docker-publish.yml
  • Running apt-get clean and deleting apt lists
  • Fixed shields links
    • Not sure where to link maintained
  • Removed Legacy Key Value Format
    • Changed ENV KEY VALUE to ENV KEY=VALUE

@traktuner traktuner mentioned this pull request Jul 27, 2024
Closed
@traktuner
Copy link
Collaborator

traktuner commented Jul 27, 2024 •
edited
Loading

Thank you for the PR. This makes maintenance easier, and I like it!

When #168 gets merged, please also add Alpine as a build variant to the Dockerfile and workflow.
After that, I will review your PR.

Thanks again!

@traktuner traktuner changed the title One build file refactor: Docker build Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dashboy1998 @traktuner