Edit run_onchange_03-install-packages.tmpl: reduce number of times chezmoi data
executes
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Claims I believe (each of which could be false and thereby make this commit wrong):
get_config
returns the same information (i.e. for each call the return value is the same)filter(lambda p: matches_features(p, get_config()), to_install)
, calls get_config() for each entry into_install
get_packages
computesdata
, anddata
contains whatget_config
returnsBased on those claims, I propose:
get_packages
returns both packages and configfilter(lambda p: matches_features(p, get_config()), to_install)
, replaceget_config()
withconfig
, whereconfig
was computed once before and is reused for each packagep