-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme update links to binaries #4806
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@@ -14,6 +14,7 @@ fi | |||
|
|||
# sort/owner/group/mtime arguments only work with gnu version of tar! | |||
${TAR} -c --sort=name --owner=root:0 --group=root:0 --mode 644 --mtime='UTC 2020-01-01' \ | |||
--exclude='*.md' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this hash actually referred to anywhere?
@@ -49,7 +49,7 @@ yarn ts-node src/test-command.ts | |||
|
|||
Some examples of how to write "scripts" is available under [./scripts/](./scripts) folder. | |||
These are "code-snippets" designed primarly for doing queries or very simple transactions. | |||
If you follow the example format you can also copy/paste them into https://testnet.joystream.org/#/js for execution. | |||
If you follow the example format you can also copy/paste them into https://polkadot.js.org/apps/#/js for execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these works...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misclicked twice on "Add single comment", but these are super nitpicky :)
- All links seem to work
- All changes are to the better
The only testnet
reference I found to be still around was in /runtime/README.md
, and probably makes sense to keep for a while.
Update Readme to not reference testnet and make binaries and chainspec easier to find on landing readme page.
Also updated shasum calculation for runtime code to exclude
.md
so in future node rebuild isn't required if we simply change some docs, as it doesn't affect the compile process.Some github actions are failing because the github runner is running out of space, a fix is available in this PR #4804 so maybe we can merge that first