Update WG budget proposal details page shows blank

[dmtrjsg]

Env: https://dao-git-ephesus-joystream.vercel.app/#/proposals/current

Proposal: https://dao-git-ephesus-joystream.vercel.app/#/proposals/preview/12

┆Issue is synchronized with this Asana task by Unito

[traumschule]

I believe there is a problem when no lead is set. The WG should be hidden from the selection.

However the proposal shows all details: https://dao-git-ephesus-joystream.vercel.app/#/proposals/preview/5
It is rejected as expected since there's no council.

[thesan]

So this comes from the QN returning the update amount as a number. The problem is that the amount is 50000000000000000 which is (one digit) greater than Number.MAX_SAFE_INTEGER as a result the bn.js throws an error.

Try this on https://atlas-next.joystream.org/query-node/server/graphql:

query {
  proposals (where: { details_json: { isTypeOf_eq: "UpdateWorkingGroupBudgetProposalDetails" } }) {
    details {
      ...on UpdateWorkingGroupBudgetProposalDetails { amount }
    }
  }
}

It's potentially a wide spread issue because although Pioneer expects strings since this change all the Float values from @/common/api/schemas/schema.graphql are returned from the QN as number. For stuff like block numbers it's fine (although Int would be more appropriate) but for JOY amount this often might trigger exceptions in bn.js. This is actually the bug that @traumschule reported here: #2327 (comment).

A quick fix here would be to just cast the amount to a string and then to a BN. However it also means a small precision loss.

I don't think this can be fixed long term on the client. @zeeshanakram3, @Lezek123 can you think of an easy fix on the QN for this ?

[thesan]

Until #3995 is merged this env can be used to pass the crashing proposals: https://dao-git-fix-proposal-view-crash-joystream.vercel.app

E.g: https://dao-git-fix-proposal-view-crash-joystream.vercel.app/#/proposals/preview/12?network-config=https://atlas-next.joystream.org/network/config.json