Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Fix proposal view crashing due to high amounts of JOY #3995

Merged
merged 1 commit into from
Jan 4, 2023
Merged

🩹 Fix proposal view crashing due to high amounts of JOY #3995

merged 1 commit into from
Jan 4, 2023

Conversation

thesan
Copy link
Member

@thesan thesan commented Dec 23, 2022 •
edited
Loading

@vercel
Copy link

vercel bot commented Dec 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 3:17PM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 3:17PM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 3:17PM (UTC)

@thesan thesan mentioned this pull request Dec 23, 2022
Closed
traumschule
traumschule approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, overlooked asBN before.

oleksanderkorn
oleksanderkorn approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@oleksanderkorn oleksanderkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thesan thesan merged commit 5378db1 into dev Jan 4, 2023
@thesan thesan deleted the fix/proposal-view-crash branch January 4, 2023 17:26
@thesan thesan restored the fix/proposal-view-crash branch January 5, 2023 11:14
@thesan thesan mentioned this pull request Jan 5, 2023
Merged
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
@thesan @XxFlameCatxX
🩹 Fix proposal view crashing due to high amounts of JOY (Joystream#3995)
7213287 
Fix proposal view crashing due to high amounts of JOY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksanderkorn oleksanderkorn oleksanderkorn approved these changes

@traumschule traumschule traumschule approved these changes

@dmtrjsg dmtrjsg Awaiting requested review from dmtrjsg

@WRadoslaw WRadoslaw Awaiting requested review from WRadoslaw

Assignees
No one assigned
Labels
jsg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesan @oleksanderkorn @traumschule