Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parent checks in reshape tests #363

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 2, 2024

On julia nightly, a reshaped Array with identical axes is no longer considered identical to the original array:

julia> A = zeros(2,2);

julia> B = reshape(A, axes(A)...);

julia> A === B # used to be true
false

Because of this, we can't check that the parents of reshaped OffsetArrays are identical anymore. In this PR, these tests are removed. The checks on the reshaped arrays should be enough here.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (97d3bf1) to head (8c4cfcb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   98.67%   96.46%   -2.22%     
==========================================
  Files           6        6              
  Lines         453      452       -1     
==========================================
- Hits          447      436      -11     
- Misses          6       16      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 7d3ea6c into master Dec 3, 2024
16 of 17 checks passed
@jishnub jishnub deleted the jishnub/reshape_parent branch December 3, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant