Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semgrep version #7

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Update semgrep version #7

merged 7 commits into from
Feb 15, 2024

Conversation

sjkelly
Copy link
Contributor

@sjkelly sjkelly commented Feb 14, 2024

This may have an issue with interpreting the GHA YAML files as part of the ruleset.

This may have an issue with interpreting the GHA YAML files as part of the ruleset.
@savq
Copy link
Contributor

savq commented Feb 14, 2024

This may have an issue with interpreting the GHA YAML files as part of the ruleset.

Yep. I was having the same issue yesterday, and I haven't managed to get .semgrepignore to work in this case.

The simplest solution here would be to change the validation command to semgrep --validate --config rules. But that doesn't work if the rules directory has submodules...

@sjkelly
Copy link
Contributor Author

sjkelly commented Feb 15, 2024

The behavior change was introduced between 1.56 and 1.57. I am going to file an issue.

@sjkelly
Copy link
Contributor Author

sjkelly commented Feb 15, 2024

I modified the GHA to run on both a specified version and latest to catch this in the future.

@sjkelly sjkelly merged commit 995dc23 into main Feb 15, 2024
1 of 2 checks passed
@savq savq deleted the sjk/semgrep_bump1 branch February 29, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants