Skip to content

Commit

Permalink
Merge pull request #17 from kuszmaul/bck-aqua-ambiguity
Browse files Browse the repository at this point in the history
Specify that the first argument to `get!(func, ::MultiThreadedCache, key)` is `Base.Callable`.
  • Loading branch information
nickrobinson251 authored Jan 23, 2025
2 parents ad3f8ae + 03586fb commit a0ed383
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MultiThreadedCaches"
uuid = "18056a9e-ed0c-4ef3-9ad7-376a7fb08032"
authors = ["Nathan Daly <[email protected]> and contributors"]
version = "0.1.3"
version = "0.1.4"

[compat]
julia = "1.3"
Expand Down
2 changes: 1 addition & 1 deletion src/MultiThreadedCaches.jl
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ end

const CACHE_MISS = :__MultiThreadedCaches_key_not_found__

function Base.get!(func, cache::MultiThreadedCache{K,V}, key) where {K,V}
function Base.get!(func::Base.Callable, cache::MultiThreadedCache{K,V}, key) where {K,V}
# If the thread-local cache has the value, we can return immediately.
# We store tcache in a local variable, so that even if the Task migrates Threads, we are
# still operating on the same initial cache object.
Expand Down

2 comments on commit a0ed383

@nickrobinson251
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/123562

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.4 -m "<description of version>" a0ed3836734a03a2f603454bd8432f222899ff29
git push origin v0.1.4

Please sign in to comment.