-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for default values to TYPEDSIGNATURES
#170
Open
JamesWrigley
wants to merge
13
commits into
JuliaDocs:master
Choose a base branch
from
JamesWrigley:default-values
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b22f594 - Browse repository at this point
Copy the full SHA b22f594View commit details
Commits on Aug 15, 2024
-
Add support for default values to
TYPEDSIGNATURES
This is done by making `TypedMethodSignatures` interpolatable and giving it the Expr of the thing the docstring is bound to. From the AST we can parse each arguments name, type annotation, default value, and whether or not it's variadic. Currently only the default value is used in `TYPEDSIGNATURES`, though in the future it might be an idea to use the type information as well.
Configuration menu - View commit details
-
Copy full SHA for 617ae4a - Browse repository at this point
Copy the full SHA 617ae4aView commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1c80865 - Browse repository at this point
Copy the full SHA 1c80865View commit details -
Configuration menu - View commit details
-
Copy full SHA for 594593e - Browse repository at this point
Copy the full SHA 594593eView commit details
Commits on Aug 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for de0f36b - Browse repository at this point
Copy the full SHA de0f36bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1b97f7 - Browse repository at this point
Copy the full SHA d1b97f7View commit details
Commits on Aug 19, 2024
-
Make the Expr optional for MethodSignatures
It won't be available when used in templates.
Configuration menu - View commit details
-
Copy full SHA for fe01fe3 - Browse repository at this point
Copy the full SHA fe01fe3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1532071 - Browse repository at this point
Copy the full SHA 1532071View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7fed390 - Browse repository at this point
Copy the full SHA 7fed390View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f1c9145 - Browse repository at this point
Copy the full SHA f1c9145View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1efecf6 - Browse repository at this point
Copy the full SHA 1efecf6View commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 79783e4 - Browse repository at this point
Copy the full SHA 79783e4View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ebb95a9 - Browse repository at this point
Copy the full SHA ebb95a9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.