Fix handling of remote URLs for standard libraries, tag 1.2.2 #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are necessary to fix the generation of source URLs for standard libraries in the Julia manual.
relpath_from_remote_rootwe no longer expand symlinks in the docstring metadata filepaths. This is because for normal builds, the standard libraries inusr/share/julia/stdlib/...are symlinked tostdlib/, and this way we can handle both the CI build and normal build the same way. At the same time, it also doesn't seem important for the packages, since I wouldn't expect there to be any symlinks there normally./cache/*ones. So if the path doesn't exists, we'll callBase.fixup_stdlib_pathon it, to see if that allows us to find the actual source path.X-ref: JuliaLang/julia#47105 (comment)