Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests less noisy and actually test logging messages #94

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Make tests less noisy and actually test logging messages #94

merged 1 commit into from
Sep 24, 2024

Conversation

giordano
Copy link
Contributor

No description provided.

@giordano
Copy link
Contributor Author

Could also make Pkg commands less noisy by passing io=devnull, but I don't know if you want to keep that visible in case something fails.

@mortenpi
Copy link
Member

LGTM. Having the Pkg output on failures would be useful, and it's not that noisy, so I think it's fine to keep the output.

FWIW, in Documenter test, we use the @quietly macro which hides all output by default, but prints if there are any errors thrown: https://github.com/JuliaDocs/Documenter.jl/blob/a0257f939c2be20c7a68ecc02c4ada8210f29495/test/TestUtilities.jl#L46-L104

@mortenpi mortenpi enabled auto-merge (squash) September 24, 2024 02:17
@mortenpi mortenpi merged commit 7a8821c into JuliaDocs:master Sep 24, 2024
12 checks passed
@giordano giordano deleted the mg/test-test-logs branch September 24, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giordano @mortenpi