Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation #430

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix deprecation #430

wants to merge 2 commits into from

Conversation

kahaaga
Copy link
Member

@kahaaga kahaaga commented Oct 8, 2024

In #427, I fixed the error disallowing different-type outcome containers for Probabilities. However, that introduced the deprecation warning again. This fixes the resulting deprecations warning.

@kahaaga
Fix deprecation
4c86c3b 
I fixed the error disallowing different-type outcome containers. However, that introduced the deprecation warning again. This fixes the resulting deprecations warning.
Datseris
Datseris approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increment patch, merge, and tag, please.

@Datseris
Copy link
Member

Datseris commented Oct 8, 2024

AH NO! Test fail!!!!!!!!

@kahaaga
Copy link
Member Author

kahaaga commented Oct 8, 2024

Test fails are unrelated. Seems like a random tolerance thing related to the sum of probabilities. We can safely merge this without affecting anything else.

Datseris
Datseris requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test have been restarted 5 times by now but they still fail. I think the failure should be fixed. It isn't even a test failure but an @assert statement failing. It isn't failing on main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Datseris Datseris Datseris requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kahaaga @Datseris