Adding support for EPSG:5070 and Albers projections generally #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliascarv
requested changes
Oct 25, 2024
eliascarv
requested changes
Oct 25, 2024
Co-authored-by: Elias Carvalho <[email protected]>
Co-authored-by: Elias Carvalho <[email protected]>
Co-authored-by: Elias Carvalho <[email protected]>
Co-authored-by: Elias Carvalho <[email protected]>
Co-authored-by: Elias Carvalho <[email protected]>
eliascarv
requested changes
Oct 25, 2024
eliascarv
requested changes
Oct 25, 2024
eliascarv
requested changes
Oct 25, 2024
eliascarv
requested changes
Oct 25, 2024
Co-authored-by: Elias Carvalho <[email protected]>
Co-authored-by: Elias Carvalho <[email protected]>
Various code style changes, changing ^0.5 to sqrt, inlined small helper function, split vectorized array operations to convert degrees to radians into individual lines, fixed missing and redundant type parameters. Learning! Co-authored-by: Elias Carvalho <[email protected]>
Co-authored-by: Elias Carvalho <[email protected]>
eliascarv
requested changes
Oct 25, 2024
eliascarv
requested changes
Oct 25, 2024
eliascarv
requested changes
Oct 25, 2024
removed divide by a since this is performed in another step, reordered constants, shifted constants so that all operations on \lambda and \phi occur within locally defined functions Co-authored-by: Elias Carvalho <[email protected]>
eliascarv
requested changes
Oct 25, 2024
… computing each time, using auth2geod Co-authored-by: Elias Carvalho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 97.29% 97.42% +0.13%
==========================================
Files 31 32 +1
Lines 1220 1284 +64
==========================================
+ Hits 1187 1251 +64
Misses 33 33 ☔ View full report in Codecov by Sentry. |
|
I'm going through the process of building the tests (my bad on not realizing the tests extended beyond get.jl) and I've noticed some issues with the code. I need to ensure that the degrees wrap (e.g. Additionally, while any lat lon can work with Albers, it's best practice to keep it between the standard parallels. Would it be fine to use lat_1 and lat_2 for the inbounds check? |
updated so that inbounds all longitude, only standard parallels latitude and \lambda properly wraps within the function test/crs/* added tests for Albers in each I COULD NOT TEST AS OF THIS MOMENT. ALL APPROX WASNT ACCEPTING THE METHOD, I BELIEVE IT HAS TO DO WITH THE FACT THE CRS IS SHIFTED I DID DETECT > 1M INACCURACY FROM PROJ. WILL HAVE TO INVESTIGATE Additionally, selected coordinates for tests are not final.
changed eqareaalbers to allow latitudes up to \pi and included a helper function to wrap latitudes if greater than abs(\pi/2) Fixed tests to properly construct an Albers object and test it Conversions needs more work. Some of the allapprox tests failed but have submeter inaccuracy. The real issue is in back transforming. Latitudes appear to be back transforming inappropriately, so that will have to be double checked
… shifts. tests work on my machine EXCEPT for conversions. Something is wrong with the backward latitude function. The forward function for T(45), -T(90) and -T(45), -T(90) don't pass tests. Will have to investigate further. Reverted change to fy(), \rho probably isn't going to be <0 zero with my wrapping scheme.
… pass on my machine except for conversion tests 3 and 4. The forward calculation diverges from PROJ at sub meter
eliascarv
requested changes
Oct 28, 2024
eliascarv
requested changes
Oct 28, 2024
…ll do more checks later today), and removed the default constructor function Co-authored-by: Elias Carvalho <[email protected]>
…. Updated tests to use the results from Proj.jl and EPSG:4269 (previously used general Proj with EPSG:4326). changed \Theta's to \theta to reflect documentation. updated backwards \theta to switch signs of arguments if n <0 based on latest EPSG guidance note.
…fSystems.jl into JC_add5070_albers
|
@souma4, I made some adjustments to your PR, I hope I helped. |
|
You have helped immensely. Got me more in the "developer/maintainer" mindset which is a good experience. And I'll likely contribute to this broader ecosystem more. Thanks for bearing with my issues in the process, hah. |
eliascarv
reviewed
Oct 29, 2024
juliohm
requested changes
Oct 29, 2024
There was a problem hiding this comment.
@souma4 this PR looks amazing. Thank you @eliascarv for adjusting it.
juliohm
approved these changes
Oct 29, 2024
eliascarv
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #183. In short, adding support for EPSG: 5070 and added Albers projection into src/crs/projected/