-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration with project.el #108
base: master
Are you sure you want to change the base?
Conversation
bb699ca
to
f99e8c0
Compare
This code is already used by eglot-jl to locate Julia projects and will be useful in the future for other Julia packages (such as for REPLs to decide which files they're associated with). Putting it in the julia-mode package means it doesn't have to be redefined each time it's used.
f99e8c0
to
8118a26
Compare
This doesn't byte-compile cleanly on Emacs 24 since |
6de9863
to
31ab9cf
Compare
Attempt to install cl-generic forward-compatibility package from elpa for testing Emacs 24.
31ab9cf
to
a0870a5
Compare
I am wondering if any package other than Also, I am reluctant to add a feature that only works on Emacs 25+, since we still support Emacs 24. |
I found myself wanting this while working on #106, which is the reason I opened it. Still might not be worthwhile if trying to support Emacs 24. |
Can this be merged now that the minimum required Emacs version is 26.1? |
@berquist What's your use-case for having this code in julia-mode? |
This code is already used by eglot-jl to locate Julia projects and
will be useful in the future for other Julia packages (such as for
REPLs to decide which files they're associated with). Putting it in
the julia-mode package means it doesn't have to be redefined each time
it's used.