Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration with project.el #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

non-Jedi
Copy link
Contributor

This code is already used by eglot-jl to locate Julia projects and
will be useful in the future for other Julia packages (such as for
REPLs to decide which files they're associated with). Putting it in
the julia-mode package means it doesn't have to be redefined each time
it's used.

@non-Jedi non-Jedi force-pushed the project-integration branch 4 times, most recently from bb699ca to f99e8c0 Compare March 23, 2020 01:39
This code is already used by eglot-jl to locate Julia projects and
will be useful in the future for other Julia packages (such as for
REPLs to decide which files they're associated with). Putting it in
the julia-mode package means it doesn't have to be redefined each time
it's used.
@non-Jedi
Copy link
Contributor Author

non-Jedi commented Mar 23, 2020

This doesn't byte-compile cleanly on Emacs 24 since cl-defmethod was added in 25.1, however all tests pass since that section is never executed since the 'project feature was also added in 25.1. I'm sure there's a way to work around this, but I don't know how off the top of my head. Using defmethod instead of cl-defmethod isn't flexible enough in this case.

@non-Jedi non-Jedi force-pushed the project-integration branch 3 times, most recently from 6de9863 to 31ab9cf Compare March 23, 2020 02:45
Attempt to install cl-generic forward-compatibility package from elpa
for testing Emacs 24.
@tpapp
Copy link
Collaborator

tpapp commented Mar 23, 2020

I am wondering if any package other than eglot-jl uses/needs something like this.

Also, I am reluctant to add a feature that only works on Emacs 25+, since we still support Emacs 24.

@non-Jedi
Copy link
Contributor Author

non-Jedi commented Mar 23, 2020

I found myself wanting this while working on #106, which is the reason I opened it. Still might not be worthwhile if trying to support Emacs 24.

@berquist
Copy link

Can this be merged now that the minimum required Emacs version is 26.1?

@non-Jedi
Copy link
Contributor Author

@berquist What's your use-case for having this code in julia-mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants