"clblas" -> "homebrew/science/clblas" #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Does this not require |
|
That's more a comment about the branch sd/osx then this pull request, but I can fix it |
|
REQUIRE file already has |
|
ah... ignore my comment then |
|
Travis isn't happy because CI isn't configured to work with OpenCL-enabled devices, but it's a separate issue. Do tests pass on your machine? |
|
No, but due to #32 |
|
I guess we can merge this then and figure out #32 separately! |
|
This doesn't make much sense if MacOS version eventually doesn't work, but I agree that it also doesn't hurt if we have it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brew name