Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal: Remove ability to generate binary libraries. #548

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Feb 19, 2024

Instead, Metal.jl will use a more portable tool to downgrade the IR and build the library in Julia.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (fd8f36d) 54.62% compared to head (3d19745) 0.00%.

Files Patch % Lines
src/metal.jl 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #548       +/-   ##
==========================================
- Coverage   54.62%   0.00%   -54.63%     
==========================================
  Files          24      24               
  Lines        3275    3226       -49     
==========================================
- Hits         1789       0     -1789     
- Misses       1486    3226     +1740     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit a95fd25 into master Feb 20, 2024
12 of 13 checks passed
@maleadt maleadt deleted the tb/rm_metallib branch February 20, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant