-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement _ParametricGeometry #138
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
===========================================
+ Coverage 95.86% 100.00% +4.13%
===========================================
Files 17 18 +1
Lines 290 284 -6
===========================================
+ Hits 278 284 +6
+ Misses 12 0 -12 ☔ View full report in Codecov by Sentry. |
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first review.
Ah, good catch. I forgot to remove the |
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes
_ParametricGeometry <: Meshes.Geometry
type to serve as a simple wrapper for custom parametric functions_parametric(geometry, ts...)
.BezierCurve
andTetrahedron
geometries, closing Integral onTetrahedron
not fully supported #40. This achieved an 80x performance improvement for integrals over aBezierCurve
.jacobian(::BezierCurve, ts, ::Analytical)
method - performance was inferior to the genericFiniteDifference
method.extended
tag fromTetrahedron
tests now that they return in reasonable CI timespans.Base.zeros
to_zeros
, providingHAdaptiveCubature
integrals with an up to 20% performance improvement.Discussion
This is a follow-up to #131, where the scope of changes had become over-extended. Some of those changes were implemented separately in other PR’s.
I’ve chosen not to also tackle other specialization geometries yet, since those seemed to suffer performance penalties. Those implementations are left for future work.