Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for nightly #42

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Fixes for nightly #42

merged 5 commits into from
Jan 17, 2024

Conversation

Pangoraw
Copy link
Member

@Pangoraw Pangoraw commented Jan 16, 2024

Closes #41

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c370d5c) 1.90% compared to head (0ef7d44) 2.70%.

Files Patch % Lines
src/Dialects.jl 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #42      +/-   ##
========================================
+ Coverage   1.90%   2.70%   +0.80%     
========================================
  Files        107     107              
  Lines      26054   26058       +4     
========================================
+ Hits         496     706     +210     
+ Misses     25558   25352     -206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy merged commit 176e4f0 into main Jan 17, 2024
3 of 4 checks passed
@Pangoraw Pangoraw deleted the pb/fix-oss branch January 17, 2024 18:03
@vchuravy vchuravy mentioned this pull request Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure on nightly due to no method matching unsafe_convert(::Type{Ptr{Nothing}}, ::IOBuffer)
3 participants