Skip to content

Commit

Permalink
src/jloptions.c: fix buggy use of strchr (#34432)
Browse files Browse the repository at this point in the history
  • Loading branch information
@StefanKarpinski @Keno
StefanKarpinski authored and Keno committed Jan 19, 2020
1 parent f120989 commit 248bc46
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/jloptions.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ JL_DLLEXPORT void jl_parse_opts(int *argcp, char ***argvp)
c = o->val;
goto restart_switch;
}
else if (strchr(shortopts, o->val)) {
else if (o->val <= 0xff && strchr(shortopts, o->val)) {
jl_errorf("option `-%c/--%s` is missing an argument", o->val, o->name);
}
else {
Expand Down

4 comments on commit 248bc46

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

Please sign in to comment.