Skip to content

Commit

Permalink
remove fence that GC change made unnecessary (#56986)
Browse files Browse the repository at this point in the history
@gbaraldi and I think that this fence can probably be removed now that
#55223 is merged. This should
slightly expand the set of cases where the Memory is removable.
  • Loading branch information
oscardssmith authored Jan 10, 2025
1 parent 9211a93 commit 64706d7
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/cgutils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4463,8 +4463,6 @@ static void emit_memory_zeroinit_and_stores(jl_codectx_t &ctx, jl_datatype_t *ty
auto len_store = ctx.builder.CreateAlignedStore(nel, len_field, Align(sizeof(void*)));
auto aliasinfo = jl_aliasinfo_t::fromTBAA(ctx, ctx.tbaa().tbaa_memorylen);
aliasinfo.decorateInst(len_store);
//This avoids the length store from being deleted which is illegal
ctx.builder.CreateFence(AtomicOrdering::Release, SyncScope::SingleThread);
// zeroinit pointers and unions
if (zi) {
Value *memory_ptr = ctx.builder.CreateStructGEP(ctx.types().T_jlgenericmemory, decay_alloc, 1);
Expand Down

0 comments on commit 64706d7

Please sign in to comment.