Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryBuilder dependencies bump #34242

Merged
merged 6 commits into from
Jan 19, 2020
Merged

BinaryBuilder dependencies bump #34242

merged 6 commits into from
Jan 19, 2020

Conversation

staticfloat
Copy link
Member

This PR contains a number of BinaryBuilder-related improvements:

  • Upgrade the BB tarball naming methodology from the flawed -gccX tags to the much more explicit -libgfortranX tags that BB has been spitting out for over half a year now. This necessitates changing Openlibm, OpenBLAS and LLVM at the least, as all of these dependencies were marked as having a dependency on GCC version/libgfortran version.
  • Upgrade OpenLibm to a new release that happily removes the incorrect dependence on libgfortran.
  • Upgrade OpenBLAS to v0.3.7, including the new threading patches from @Keno.
  • Re-name the LLVM checksums to honor the upgraded naming convention.

@ViralBShah ViralBShah added the building Build system, or building Julia or its dependencies label Jan 2, 2020
@staticfloat
Copy link
Member Author

staticfloat commented Jan 3, 2020

And because I often screw this up, here is a build with no BB dependencies: https://build.julialang.org/#/builders/147/builds/8

@staticfloat
Copy link
Member Author

Hmmm, win32 has a signal 11 (is that still segfault on windows?) when just trying to run Julia to print out version info. That's not good.

@Keno
Copy link
Member

Keno commented Jan 3, 2020

I'm seeing even the shell segfault: https://build.julialang.org/#/builders/31/builds/8176/steps/3/logs/stdio. Did the BinaryBuilder download overwrite something?

@JeffBezanson
Copy link
Member

This is great but it's not clear to me whether it's backportable --- maybe we should merge #34225 for now? Or perhaps only on release-1.4?

@staticfloat
Copy link
Member Author

Did the BinaryBuilder download overwrite something?

Unsure; I looked into the logs and it seems that a lot of the builders have been segfaulting. I've rebooted them to see if that fixes it, if not I'll inspect the bots a bit, and if I can't figure it out quickly, I'll just rebuild them.

@staticfloat
Copy link
Member Author

To play it safe, I think I should build a special 0.3.5 release of OpenBLAS with Keno's patches, integrate those into #34225, land those on 1.3/1.4, and this can go into master.

staticfloat and others added 6 commits January 18, 2020 14:24
It's also no longer libgfortran-dependent, so flip that flag and
reduce the number of separate files by 2/3rds.
This will require us to change our LLVM and OpenBLAS binaries, as they
are the only libgfortran-specific libraries that we ship with base Julia.
After much debugging, it turns out that OpenBlas is sometimes hanging
on exit due to bad assumptions in its thread management. The upstream
discussion is at OpenMathLib/OpenBLAS#2350, but this
should fix our frequent win32 CI failures in the meantime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants