irrationals: restrict assume effects annotations to known types #55886
+34
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes:
:total
with the less powerful:foldable
<:Integer
dispatch constraint on therationalize
method, closes fix dispatch constraint on arg on rationalize for AbstractIrrational #55872Rational{<:Integer}
with justRational
, they're equalOther issues, related to
BigFloat
precision, are still present in irrationals.jl, to be fixed by followup PRs, including #55853.Fixes #55874