-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark require_one_based_indexing
and has_offset_axes
as public
#56196
Open
adrhill
wants to merge
4
commits into
JuliaLang:master
Choose a base branch
from
adrhill:ah/public-require-one-based
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
feature
Indicates new feature / enhancement requests
needs docs
Documentation for this change is required
needs news
A NEWS entry is required for this change
labels
Oct 16, 2024
It'd be much better to have them documented outside of the devdocs though. |
Do you want me to include them somewhere? |
"Indexing and assignment" is probably a better fit. |
mbauman
reviewed
Oct 21, 2024
Co-authored-by: Matt Bauman <[email protected]>
Tagging triage because this adds new API. |
LilithHafner
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion here mentions
require_one_based_indexing
being part of the public API: #43263Both functions are also documented (albeit in the dev docs):
require_one_based_indexing
: https://docs.julialang.org/en/v1/devdocs/offset-arrays/#man-custom-indiceshas_offset_axes
: https://docs.julialang.org/en/v1/devdocs/offset-arrays/#For-objects-that-mimic-AbstractArray-but-are-not-subtypesTowards #51335.