Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark require_one_based_indexing and has_offset_axes as public #56196

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adrhill
Copy link
Contributor

@adrhill adrhill commented Oct 16, 2024

The discussion here mentions require_one_based_indexing being part of the public API: #43263

Both functions are also documented (albeit in the dev docs):

Towards #51335.

@nsajko nsajko added feature Indicates new feature / enhancement requests needs docs Documentation for this change is required needs news A NEWS entry is required for this change labels Oct 16, 2024
@giordano
Copy link
Contributor

Both functions are also documented (albeit in the dev docs)

It'd be much better to have them documented outside of the devdocs though.

@adrhill
Copy link
Contributor Author

adrhill commented Oct 17, 2024

Do you want me to include them somewhere?
I'm not sure which section in docs.julialang.org/en/v1/base/arrays/ is best suited. Maybe "Array functions"?

@adrhill
Copy link
Contributor Author

adrhill commented Oct 17, 2024

"Indexing and assignment" is probably a better fit.

@nsajko nsajko removed the needs docs Documentation for this change is required label Oct 19, 2024
@nsajko nsajko removed the needs news A NEWS entry is required for this change label Oct 21, 2024
doc/src/base/arrays.md Outdated Show resolved Hide resolved
@LilithHafner LilithHafner added the triage This should be discussed on a triage call label Oct 22, 2024
@LilithHafner
Copy link
Member

Tagging triage because this adds new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates new feature / enhancement requests triage This should be discussed on a triage call
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants