Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recompile comment in --trace-compile in terminal color mode too #56275

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 21, 2024

Update: Just adds the comment in color terminal mode too


I didn't think adding the # recompile text to the end in the repl was a good idea as it increases likelihood of text wrapping.
And the color should be sufficient for local review, but when people copy from a color terminal we lose the recompile info.

So this just adds a zero-length change indicator, for people to look out for.

@IanButterworth IanButterworth added the backport 1.11 Change should be backported to release-1.11 label Oct 21, 2024
@topolarity
Copy link
Member

topolarity commented Oct 21, 2024

I think we should just add "# recompile" always. I was confused about what the coloring meant when I first saw it anyway.

Adding another symbol just makes it more confusing IMO

@IanButterworth
Copy link
Member Author

Okay. Yeah

@IanButterworth IanButterworth changed the title add indicator to trace_compile stderr recompiles to survive copy-paste from color prompt add recompile comment in --trace-compile in terminal color mode too Oct 21, 2024
src/gf.c Outdated Show resolved Hide resolved
Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @IanButterworth !

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Oct 21, 2024
@oscardssmith oscardssmith merged commit e4101b7 into JuliaLang:master Oct 22, 2024
8 checks passed
@oscardssmith oscardssmith added REPL Julia's REPL (Read Eval Print Loop) and removed merge me PR is reviewed. Merge when all tests are passing labels Oct 22, 2024
@IanButterworth IanButterworth deleted the ib/trace_compile_timing_recomp_indicator branch October 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.11 Change should be backported to release-1.11 REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants