Fix fetching parent in symmetric algebra #56286
Merged
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need the
parent
of the result if it is a triangular matrix. For other structurally triangular matrices, such asDiagonal
s, we may use these directly in theHermitian
constructor.The operation proceeds as (assuming
H isa Hermitian
withH.uplo == 'U'
):This accounts for the fact that
Ures
may not be anUpperTriangular
, asuppertriangular
might be specialized by the parent. In such cases we should not extract the parent. Currently, onlyDiagonal
specializesuppertriangular
, so this issue only exists for aHermitian
or aSymmetric
that wraps aDiagonal
.Fixes #56283