Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jitlayers: use std::make_tuple instead of tuple constructor #56287

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

benlorenz
Copy link
Contributor

this should be safer for the type deduction and fixes a build error for macos on Yggdrasil (JuliaPackaging/Yggdrasil#9660):

src/jitlayers.cpp:665:54: error: no viable constructor or deduction guide for deduction of template arguments of 'tuple'
  665 |         incompletemodules.insert(std::pair(codeinst, std::tuple(std::move(params), waiting)));

The Yggdrasil environment is a bit special with a rather new clang (version 17) but an old macos sdk and I don't know exactly in which circumstances this triggers. But I think std::make_tuple should be more reliable when the tuple types are not specified.

cc: @fingolfin

this should be safer for the type deduction and fixes a build error on Yggdrasil
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Oct 22, 2024
@LilithHafner LilithHafner merged commit 7d4b2b7 into JuliaLang:master Oct 22, 2024
8 checks passed
@LilithHafner LilithHafner removed the merge me PR is reviewed. Merge when all tests are passing label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants