Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Base.is_interactive as Bool #56303

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Type Base.is_interactive as Bool #56303

merged 1 commit into from
Oct 23, 2024
+2 −2

Conversation

LilithHafner
Copy link
Member

Before, typing Base.is_interactive = 7 would cause weird internal REPL failures down the line. Now, it throws an InexactError and has no impact.

@DilumAluthge
Copy link
Member

Why isn't Base.is_interactive const?

@KristofferC
Copy link
Member

Because it needs to be set during runtime?

@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label Oct 23, 2024
@LilithHafner LilithHafner merged commit 28b0abd into master Oct 23, 2024
6 of 8 checks passed
@LilithHafner LilithHafner deleted the LilithHafner-patch-1 branch October 23, 2024 21:33
@LilithHafner LilithHafner removed the merge me PR is reviewed. Merge when all tests are passing label Oct 23, 2024
@LilithHafner
Copy link
Member Author

There's this, for example: https://github.com/JuliaLang/IJulia.jl/blob/0db1fa2c6b3f04d43a18830c631a1e46851908b6/src/kernel.jl#L44, though that should probably be replaced by launching with -i.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LilithHafner @DilumAluthge @KristofferC @IanButterworth